[Infrastructure] GitHub permissions & RFC 3647 Template
bwilson at mozilla.com
Wed Jul 1 10:46:40 MST 2020
I have the setting window open in Github. Should I mark that checkbox
all configured restrictions above for administrators.")?
On Wed, Jul 1, 2020 at 11:05 AM Ben Wilson <bwilson at mozilla.com> wrote:
> Yeah, I agree.
> On Wed, Jul 1, 2020 at 10:26 AM Ryan Sleevi <sleevi at google.com> wrote:
>> Hey Ben,
>> Not to try and call you out, but I noticed you directly committed
>> https://github.com/cabforum/documents/commit/1e60f228aefc9dabd20ab3ccd39c295c1b895aec to
>> the master without any form of pull request or review (AFAICT)
>> That's definitely not ideal, especially because it's unfortunately not
>> valid markdown.
>> We currently have branch protections enabled to prevent this, but I think
>> you may have been able to bypass these protections because we don't have
>> them enforced for administrators.
>> I think we should enforce them for administrators (via Settings ->
>> Branches -> Branch Protection -> Master -> "Include Administrators"). I
>> realize this may make it harder to make infrastructure-related changes, but
>> that seems to be a net win, overall. Do other folks agree?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Infrastructure